WebSVN – Games.Chess Giants – Diff – //chessengine.cpp

 #include "common.h"
-#include <fcntl.h>
-// definitions used in this module only
-#define RD 0
-#define WR 1
-#define CLOSE_PIPE(pipe) if (pipe[RD] != -1) _close (pipe[RD]); pipe[RD] = -1; if (pipe[WR] != -1) _close (pipe[WR]); pipe[WR] = -1
 // global variables used in this module only
-static wchar_t chessenginemodule_path[MAX_PATH];
+static wchar_t chessengine_path[MAX_PATH];
-static wchar_t chessenginemodule_pathname[MAX_PATH];
+static wchar_t chessengine_shellcommand[MAX_PATH];
 static wchar_t chessengineinitfile_pathname[MAX_PATH];
-static PROCESS_INFORMATION PlayerEngine_pi;
-static int chessgiants_to_engine[2]; // RD and WR
-static int engine_to_chessgiants[2]; // RD and WR
 static int current_obstinacy;
 static bool is_hint_pending;
+FILE *fpipe;
 // prototypes of local functions
 static void PlayerEngine_Recv (player_t *player);
 static void PlayerEngine_Send (player_t *player);
 static wchar_t *Move_BuildString (boardmove_t *move);
+{
    // this function starts a chess engine as a child process. This process's stdin and
    // stdout are redirected to the handles we give it, so that we may read/write to it.
    engineprogram_t *program;
+   wchar_t current_path[MAX_PATH];
    wchar_t widechar_buffer[256];
    SYSTEM_INFO sysinfo;
-   HANDLE hStdOut[2] = { NULL, NULL };
-   HANDLE hStdIn[2] = { NULL, NULL };
-   SECURITY_ATTRIBUTES saAttr;
-   STARTUPINFO si;
    int try_index;
    FILE *fp;
    // reset stuff first
    player->wants_hint = false;
    // quick access to engine program
    program = &options.engine.programs[options.engine.selected_program];
    // build the chess engine module path and pathname
-   swprintf_s (chessenginemodule_path, WCHAR_SIZEOF (chessenginemodule_path), L"%s/engines/%s", app_path, program->folder);
+   swprintf_s (chessengine_path, WCHAR_SIZEOF (chessengine_path), L"%s/engines/%s", app_path, program->folder);
-   swprintf_s (chessenginemodule_pathname, WCHAR_SIZEOF (chessenginemodule_pathname), L"%s/engines/%s/%s", app_path, program->folder, program->cmdline);
+   swprintf_s (chessengine_shellcommand, WCHAR_SIZEOF (chessengine_shellcommand), L"\"%s/%s\" %s", chessengine_path, program->executable_name, program->executable_arguments);
-   // build the I/O pipes
-   memset (&saAttr, 0, sizeof (saAttr)); // prepare the pipes' security attributes
-   saAttr.nLength = sizeof (SECURITY_ATTRIBUTES);
+   // start the engine behind a bidirectional I/O pipe
-   saAttr.bInheritHandle = true; // set the bInheritHandle flag so pipe handles are inherited
-   CreatePipe (&hStdIn[RD], &hStdIn[WR], &saAttr, 0); // create a pipe for the child process's stdin
-   CreatePipe (&hStdOut[RD], &hStdOut[WR], &saAttr, 0); // create a pipe for the child process's stdout
+   GetCurrentDirectory (WCHAR_SIZEOF (current_path), current_path); // save current directory
-   SetHandleInformation (hStdIn[WR], HANDLE_FLAG_INHERIT, 0); // ensure the write handle to the pipe for STDIN is not inherited
+   SetCurrentDirectory (chessengine_path); // temporarily set chess engine's startup directory as current directory
-   SetHandleInformation (hStdOut[RD], HANDLE_FLAG_INHERIT, 0); // ensure the read handle to the pipe for STDOUT is not inherited
-   engine_to_chessgiants[RD] = _open_osfhandle ((intptr_t) hStdOut[RD], _O_BINARY);
-   engine_to_chessgiants[WR] = _open_osfhandle ((intptr_t) hStdOut[WR], _O_BINARY | _O_APPEND);
-   chessgiants_to_engine[RD] = _open_osfhandle ((intptr_t) hStdIn[RD], _O_BINARY);
-   chessgiants_to_engine[WR] = _open_osfhandle ((intptr_t) hStdIn[WR], _O_BINARY | _O_APPEND);
-   // spawn the chess engine process with redirected input and output
-   memset (&si, 0, sizeof (si));
-   si.cb = sizeof (STARTUPINFOA);
-   si.dwFlags = STARTF_USESTDHANDLES;
-   si.hStdInput = hStdIn[RD];
-   si.hStdOutput = hStdOut[WR];
-   si.hStdError = hStdOut[WR];
-   if (!CreateProcess (chessenginemodule_pathname, // module pathname
+   fpipe = pipe_open (chessengine_shellcommand, L"r+");
-                       program->cmdline, // command line
-                       NULL, NULL,
-                       true, // handles are inherited
+   SetCurrentDirectory (current_path); // restore current directory
-                       CREATE_NO_WINDOW | DETACHED_PROCESS | CREATE_NEW_PROCESS_GROUP,
-                       NULL,
+   if (fpipe == NULL)
-                       chessenginemodule_path, // process path
-                       &si, // STARTUPINFO pointer
-                       &PlayerEngine_pi)) // receives PROCESS_INFORMATION
+   {
       messagebox.hWndParent = hMainWnd;
       wcscpy_s (messagebox.title, WCHAR_SIZEOF (messagebox.title), LOCALIZE (L"ImportantMessage"));
       wcscpy_s (messagebox.text, WCHAR_SIZEOF (messagebox.text), LOCALIZE (L"Error_ChessEngineInitializationFailed"));
       messagebox.flags = MB_ICONWARNING | MB_OK;
       PlayerEngine_Shutdown (player); // on error, shutdown the engine
       return (false);
+   }
-   // eventually initialize the debug log file
+   // optionally initialize the debug log file
    Debug_Init (L"Chess engine output.txt");
    // build the init file full qualified path name and try to open it
    swprintf_s (chessengineinitfile_pathname, WCHAR_SIZEOF (chessengineinitfile_pathname), L"%s/engines/%s/init.txt", app_path, program->folder);
    _wfopen_s (&fp, chessengineinitfile_pathname, L"r");
       fclose (fp); // finished, close the file
+   }
    // everything's okay, set engine name as the player's name
-   wcscpy_s (player->name, WCHAR_SIZEOF (player->name), program->name);
+   wcscpy_s (player->name, WCHAR_SIZEOF (player->name), program->friendly_name);
    return (true); // finished
+}
 void PlayerEngine_Shutdown (player_t *player)
+{
    // this function terminates the chess engine process and releases all handles attached to it
-   unsigned long exit_code;
-   unsigned long handle_flags;
    int attempt_index;
    // send the engine a quit command
    Player_SendBuffer_Add (player, 1000, options.engine.programs[options.engine.selected_program].command_quit);
    Player_SendBuffer_Add (player, 1000, L"\n"); // since the format string was read from the options, don't forget to end it with a carriage return
    PlayerEngine_Send (player);
-   // close the pipes
-   CLOSE_PIPE (chessgiants_to_engine);
-   CLOSE_PIPE (engine_to_chessgiants);
    // check 10 times if the engine process has ended cleanly
    for (attempt_index = 0; attempt_index < 10; attempt_index++)
+   {
-      if (GetExitCodeProcess (PlayerEngine_pi.hProcess, &exit_code) && (exit_code != STILL_ACTIVE))
+      if (!pipe_isalive (fpipe))
          break; // break as soon as we've told the process exited cleanly
       Sleep (100); // else wait one tenth second
+   }
-   // has the engine NOT closen by itself yet ?
-   if ((attempt_index == 10) && GetExitCodeProcess (PlayerEngine_pi.hProcess, &exit_code) && (exit_code == STILL_ACTIVE))
-   {
-      Debug_Log (L"===Engine not closen, terminating process manually===\n");
-      // terminate the chess engine process using our smart technique ^^
+   // close the pipe (this will terminate the child process if it hasn't terminated yet)
-      if (!SafeTerminateProcess (PlayerEngine_pi.hProcess, 0))
-         TerminateProcess (PlayerEngine_pi.hProcess, 0); // if process doesn't want to shutdown, kill it
-   }
-   else
-      Debug_Log (L"===Engine closed cleanly===\n");
-   if (PlayerEngine_pi.hProcess)
+   pipe_close (fpipe);
-      CloseHandle (PlayerEngine_pi.hProcess);
-   PlayerEngine_pi.hProcess = NULL;
-   if (GetHandleInformation (PlayerEngine_pi.hThread, &handle_flags))
-      CloseHandle (PlayerEngine_pi.hThread);
-   PlayerEngine_pi.hThread = NULL;
-   // and finally reset the process information structure
-   memset (&PlayerEngine_pi, 0, sizeof (PlayerEngine_pi));
+   Debug_Log (L"===Engine closed===\n");
    return; // finished
+}
 bool PlayerEngine_Think (player_t *player)
       if (!is_hint_pending && (options.engine.blunder_chances > 0) && (rand () % 100 < options.engine.blunder_chances)
           && Move_FindRandomMove (&the_board.moves[the_board.move_count - 1], player->color, &move))
+      {
          Player_SendBuffer_Add (player, 1000, program->command_force, Move_BuildString (&move)); // send the blunderous move to the engine
          Player_SendBuffer_Add (player, 1000, L"\n"); // since the format string was read from the options, don't forget to end it with a carriage return
-         if (_wcsnicmp (program->name, L"Crafty", 6) == 0)
+         if (_wcsnicmp (program->friendly_name, L"Crafty", 6) == 0)
-            Player_SendBuffer_Add (player, 1000, L"disp\n");
+            Player_SendBuffer_Add (player, 1000, L"disp\n"); // FIXME: we no longer need this Crafty-specific hack, do we?
          Debug_Log (L"===Discarding engine move, forcing a blunderous move (%s) instead===\n", Move_BuildString (&move)); // blunder
+      }
       // mark the engine's selected and hovered squares
       Board_SetSelectedAndHovered (&the_board, move.source[0], move.source[1], move.target[0], move.target[1]);
          Player_SendBuffer_Add (player, 1000, program->command_sd, options.engine.depth);
          Player_SendBuffer_Add (player, 1000, L"\n"); // since the format string was read from the options, don't forget to end it with a carriage return
          Player_SendBuffer_Add (player, 1000, program->command_setboard, the_board.moves[the_board.move_count - 1].fen_string);
          Player_SendBuffer_Add (player, 1000, L"\n"); // since the format string was read from the options, don't forget to end it with a carriage return
-         if (_wcsnicmp (program->name, L"Crafty", 6) == 0)
+         if (_wcsnicmp (program->friendly_name, L"Crafty", 6) == 0)
-            Player_SendBuffer_Add (player, 1000, L"disp\n");
+            Player_SendBuffer_Add (player, 1000, L"disp\n"); // FIXME: we no longer need this Crafty-specific hack, do we?
+      }
       do_update = true; // remember to update the 3D scene
+   }
       Player_SendBuffer_Add (player, 1000, L"\n"); // since the format string was read from the options, don't forget to end it with a carriage return
       current_obstinacy = 0; // reset current obstinacy
       is_hint_pending = false; // no hint was requested so far
-      if (_wcsnicmp (program->name, L"Crafty", 6) == 0)
+      if (_wcsnicmp (program->friendly_name, L"Crafty", 6) == 0)
-         Player_SendBuffer_Add (player, 1000, L"disp\n");
+         Player_SendBuffer_Add (player, 1000, L"disp\n"); // FIXME: we no longer need this Crafty-specific hack, do we?
+   }
    // have we been notified that players are swapping colors ? (N.B. when this happens in human vs. computer mode, it's always that the human player is *GIVING* his turn)
    if (the_board.want_playerswap)
+   {
+      {
          // is it NOT a board setup AND has at least one move been played (meaning it was just the other's turn before) ?
          if (!the_board.was_setup && (the_board.move_count > 1))
+         {
             Debug_Log (L"===Player just played, sending the chosen move to engine===\n");
-            if (_wcsnicmp (program->name, L"Crafty", 6) == 0)
+            if (_wcsnicmp (program->friendly_name, L"Crafty", 6) == 0)
-               Player_SendBuffer_Add (player, 1000, L"disp\n");
+               Player_SendBuffer_Add (player, 1000, L"disp\n"); // FIXME: we no longer need this Crafty-specific hack, do we?
             // instruct it about its allowed search depth BEFORE each move (this ensures engine will be "ready" to handle the command)
             // then build the move string, and send the move string to the engine
             Player_SendBuffer_Add (player, 1000, program->command_sd, options.engine.depth);
             Player_SendBuffer_Add (player, 1000, L"\n"); // since the format string was read from the options, don't forget to end it with a carriage return
          Player_SendBuffer_Add (player, 1000, program->command_sd, options.engine.depth);
          Player_SendBuffer_Add (player, 1000, L"\n"); // since the format string was read from the options, don't forget to end it with a carriage return
          Player_SendBuffer_Add (player, 1000, program->command_setboard, the_board.moves[the_board.move_count - 1].fen_string);
          Player_SendBuffer_Add (player, 1000, L"\n"); // since the format string was read from the options, don't forget to end it with a carriage return
-         if (_wcsnicmp (program->name, L"Crafty", 6) == 0)
+         if (_wcsnicmp (program->friendly_name, L"Crafty", 6) == 0)
-            Player_SendBuffer_Add (player, 1000, L"disp\n");
+            Player_SendBuffer_Add (player, 1000, L"disp\n"); // FIXME: we no longer need this Crafty-specific hack, do we?
          do_update = true; // remember to update the 3D scene
+      }
+   }
    // get reception buffer's initial end position
    initial_pos = wcslen (player->recvbuffer);
    length = initial_pos;
    // as long as the pipe reports us there is data to read, read one byte at a time
-   while (!_eof (engine_to_chessgiants[RD]))
+   while (pipe_hasdata (fpipe))
+   {
-      read_count = _read (engine_to_chessgiants[RD], player->ascii_recvbuffer, 1);
+      read_count = pipe_read (fpipe, player->ascii_recvbuffer, 1);
       if (read_count == 0)
          break; // read the pipe; if it fails, stop trying
       if ((player->ascii_recvbuffer[0] == '\r') || (player->ascii_recvbuffer[0] == '%'))
          continue; // ignore carriage returns and percent signs
    line_pointer = player->sendbuffer; // start at the first character
    while ((line_pointer = wcsgets (widechar_buffer, WCHAR_SIZEOF (widechar_buffer), line_pointer)) != NULL)
+   {
       wcscat_s (widechar_buffer, WCHAR_SIZEOF (widechar_buffer), L"\n"); // put the carriage return back
       ConvertTo7BitASCII (ascii_buffer, sizeof (ascii_buffer), widechar_buffer); // convert to ASCII
-      amount_written = _write (chessgiants_to_engine[WR], ascii_buffer, strlen (ascii_buffer)); // send data
+      amount_written = pipe_write (fpipe, ascii_buffer, strlen (ascii_buffer)); // send data
+   }
    player->sendbuffer[0] = 0; // what we had to send has been sent, reset the send buffer
    player->sendbuffer_locked = false; // and unlock it

Subversion Repositories Games.Chess Giants

Games.Chess Giants//chessengine.cpp – Rev 149 → 150